Fix aws-crt-swift by moving PKCS#11 headers #473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like Swift is trying to individually process these files because they're under include/, even if we we add these files to the `exclude` list. The official PKCS#11 headers cannot be parse individually. The user is required to `#define` a few things before `#include`ing them. Moving these headers out from under the the include/ folder fixes the issue
sbSteveK
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
aws-crt-swift is breaking when Swift tries to compile the official PKCS#11 headers.
These headers weird and need a bunch of things
#definedbefore they're#included. Seems like Swift is trying to compile/parse each individual header underinclude/..., even if we add these files to the exclude listDescription of changes:
Move official PKCS#11 headers (and all files that include them) out from under the
include/...folder.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.