TypePredicate filter: better overload matching #817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that when the type predicate takes `any` argument, TypeScript does not always select the proper `filter()` overload. Now the `TypePredicate` type takes also the original type `V` and the checked-for type `S extends V`. This seems to solve the problems.
|
Merged and released 3.0.22 |
|
BTW should the documentation at https://baconjs.github.io/ be automatically regenerated? It seems it's not. |
|
It's not that automatic. Needs to be built and pushed, that is. |
|
There's a lot that could be better, and as I've mentioned, I haven't been actively working on anything bacon.js related for years. |
|
Anyways, built and pushed. Thanks for pointing this out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that when the type predicate takes
anyargument, TypeScript does not always select the properfilter()overload. Now theTypePredicatetype takes also the original typeVand the checked-for typeS extends V. This seems to solve the problems.