chore(ci): add build manager #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
align Makefile with steps in .travis.yml to build easily locally. just `make` or `make PHP=php8.2 test`.
in the Microsoft GitHub Action workflows to removes noise from the logs.
ktomk
added a commit
to ktomk/symfony-console-autocomplete
that referenced
this pull request
Dec 22, 2022
in 0623ac8 (chore(ci): add build manager (bamarni#75), 2022-12-21) the bats install is out-of-tree. move it in.
ktomk
added a commit
to ktomk/symfony-console-autocomplete
that referenced
this pull request
Dec 22, 2022
in 0623ac8 (chore(ci): add build manager (bamarni#75), 2022-12-21) the .travis.yml steps install and test were aligned in Makefile to install and test. for test this is fine, but for install it conflicts with the well known make install goal, which would mean to install bin/symfony-autocomplete under prefix. untangle with new install/uninstall-build-deps goals that handle build dependencies only (e.g. bats). has consequences for clean goal as there is no need to remove the bats git clone in build/bats for a clean build. this is why build/b* is excluded in clean (c.f. `build/[ac-z]*`), b* stands for bats.
ktomk
added a commit
to ktomk/symfony-console-autocomplete
that referenced
this pull request
Dec 22, 2022
in 0623ac8 (chore(ci): add build manager (bamarni#75), 2022-12-21) the .travis.yml steps install and test were aligned in Makefile to install and test. for test this is fine, but for install it conflicts with the well known make install goal, which would mean to install bin/symfony-autocomplete under prefix. untangle with new install/uninstall-build-deps goals that handle build dependencies only (e.g. bats). has consequences for clean goal as there is no need to remove the bats git clone in build/bats for a clean build. this is why build/b* is excluded in clean (c.f. `build/[ac-z]*`), b* stands for bats.
ktomk
added a commit
to ktomk/symfony-console-autocomplete
that referenced
this pull request
Dec 22, 2022
in 0623ac8 (chore(ci): add build manager (bamarni#75), 2022-12-21) the .travis.yml steps install and test were aligned in Makefile to install and test. for test this is fine, but for install it conflicts with the well known make install goal, which would mean to install bin/symfony-autocomplete under prefix. untangle with new install/uninstall-build-deps goals that handle build dependencies only (e.g. bats). has consequences for clean goal as there is no need to remove the bats git clone in build/bats for a clean build. this is why build/b* is excluded in clean (c.f. `build/[ac-z]*`), b* stands for bats.
ktomk
added a commit
to ktomk/symfony-console-autocomplete
that referenced
this pull request
Dec 22, 2022
in 0623ac8 (chore(ci): add build manager (bamarni#75), 2022-12-21) the .travis.yml steps install and test were aligned in Makefile to install and test. for test this is fine, but for install it conflicts with the well known make install goal, which would mean to install bin/symfony-autocomplete under prefix. untangle with new install/uninstall-build-deps goals that handle build dependencies only (e.g. bats). has consequences for clean goal as there is no need to remove the bats git clone in build/bats for a clean build. this is why build/b* is excluded in clean (c.f. `build/[ac-z]*`), b* stands for bats.
ktomk
added a commit
to ktomk/symfony-console-autocomplete
that referenced
this pull request
Dec 22, 2022
in 0623ac8 (chore(ci): add build manager (bamarni#75), 2022-12-21) the bats install is out-of-tree. move it in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to more easily build the project locally, add GNU make as build manager, just
make.current workflow is aligned with configuration in travis.yml, the php command defaults to
phpand can be configured withPHP=php8.2.the build is leaving the project tree for
batswhich goes to/tmp/batsand/tmp/local, which is from the current configuration.github workflow configuration also updated to the current PHP version and deprecation noise reduced for the remote dependencies.