set xdebug ini #1257
Merged
set xdebug ini #1257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So do we still need to skip the test? |
|
Oh, good point…I just removed. |
|
Yeah doesn't work :( |
|
I’ve been using phpunit 9.5.x but looks like your tests are using phpunit 8.5.x. The phpunit.dist.xml change does not work for phpunit 8.5 but php’s |
|
Apparently that doesn’t work either. Should I add the conditional skip-test back? |
|
Hmm I guess |
This reverts commit e25e46e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #1224 (comment), #1256
@barryvdh I tried using
ini_set('xdebug.file_link_format', 'vscode://file/%f:%l')insetUp()and it just wouldn’t set it. I also tried thesetUpBeforeClass()method from phpunit to hook in a bit earlier and that didn’t work either.Setting it in the phpunit.xml.dist file was the only way I was able to add that in so it would run.