Set default base path for xdebug replacements #1506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay like this it seems to work without setting anything in local development (eg. Herd/Valet), and just setting the local settings for ignition fixes both ignition and debugbar the same way :) |
|
|
|
Yeah it uses the same logic anyways |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm still not really sure if this is correct. It seems so be copied from Ignition in #1258 by @VictoRD11 ?
But should both default to the base_path?
Eg. in Laravel Herd this works fine by default, with
getRemoteServerReplacements()looking like this:But not sure if this is intended like this. And should we default to the Ignition .env?
/cc @ erikn69