Skip to content

Preserve laravel error handler #1760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2025
Merged

Conversation

erikn69
Copy link
Contributor

@erikn69 erikn69 commented Mar 11, 2025

Based on php-debugbar/php-debugbar#748

Wouldn't this conflict with the existing error handler?
php-debugbar/php-debugbar#748 (comment)

We are currently replacing the Laravel error handler,
this removes some functionality, such as deprecation control, look at: laravel/framework/Illuminate/Foundation/Bootstrap/HandleExceptions.php#L69-L76

The throw is returned to the framework and only the data is captured


If php-debugbar/php-debugbar#748 get merged, we could go from this

$this->addThrowable($exception);

to this

$this->addWarning($level, $message, $file, $line);

which would considerably reduce the size of the collect in case of many notices/deprecations

@barryvdh barryvdh merged commit 376ebb1 into barryvdh:master Mar 21, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants