Skip to content

Stop duplicating ensure_rng in AcquisitionFunction class #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

Gerrit0
Copy link
Contributor

@Gerrit0 Gerrit0 commented Apr 27, 2025

I noticed this while porting the project to another environment

Copy link

codecov bot commented Apr 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.92%. Comparing base (1714504) to head (f10aefb).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #561      +/-   ##
==========================================
- Coverage   97.92%   97.92%   -0.01%     
==========================================
  Files          10       10              
  Lines        1158     1155       -3     
==========================================
- Hits         1134     1131       -3     
  Misses         24       24              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@till-m
Copy link
Member

till-m commented Apr 28, 2025

Thanks for the PR! Out of curiosity, what are you porting this project to, and why? :)

@till-m till-m merged commit 9a464f2 into bayesian-optimization:master Apr 28, 2025
14 checks passed
@Gerrit0
Copy link
Contributor Author

Gerrit0 commented Apr 29, 2025

I needed an implementation of it in C++ - didn't want to have to call Python in order to optimize things. It was super easy to get up and running with the library with a Python plugin, so it made sense to me to port the parts I needed to C++ rather than try and find some library in that language with the same API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants