Skip to content

polish & clean code #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 3, 2025
Merged

polish & clean code #566

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
13095cf
Fix acq min bug
till-m May 17, 2025
eed1147
Update docs, make `random_state` not a property of acqs
till-m May 19, 2025
2600edb
Merge branch 'bayesian-optimization:master' into master
till-m May 19, 2025
5aaa3d2
fix giving bad seeds to l-bfgs-b
till-m May 22, 2025
4479243
remove debug code
till-m May 22, 2025
55c2840
Relax constraint.approx test slightly
till-m May 22, 2025
7bc0884
GPHedge: ensure random state
till-m May 22, 2025
acd4c54
nitpick fixes
till-m May 22, 2025
6e59e96
Make constraints work with parameter types
till-m May 23, 2025
05fc602
Use `deepcopy` when copying constraint in `ConstantLiar`
till-m May 30, 2025
27b7997
Move the instantiation of `ConstraintModel`
till-m May 30, 2025
db97f2f
Update warning
till-m May 30, 2025
c173898
remove unnecessary random state storing
till-m Jun 2, 2025
d413b76
Remove unnecessary import
till-m Jun 2, 2025
21d9aeb
Add a `.random_sample` function to the optimizer
till-m Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Relax constraint.approx test slightly
  • Loading branch information
@till-m
till-m committed May 22, 2025
commit 55c284099ea1bb359ea03a92fa3a519569e18a35
5 changes: 1 addition & 4 deletions tests/test_constraint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,7 @@ def test_single_constraint_lower_upper(target_function, constraint_function):
y = res[:, 3]

# Check accuracy of approximation for sampled points
assert constraint_function(x, y) == pytest.approx(optimizer.constraint.approx(xy), rel=1e-5, abs=1e-5)
assert constraint_function(x, y) == pytest.approx(
optimizer.space.constraint_values[:-1], rel=1e-5, abs=1e-5
)
assert constraint_function(x, y) == pytest.approx(optimizer.constraint.approx(xy), rel=1e-4, abs=1e-4)


def test_multiple_constraints(target_function):
Expand Down
Loading