Skip to content

feat(gazelle): Include types/stubs packages #2425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 8, 2024
Merged

feat(gazelle): Include types/stubs packages #2425

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
143267d
feat(gazelle): Include types/stubs packages that have them
ewianda Nov 18, 2024
95e438f
Add unit test
ewianda Nov 21, 2024
a4fa177
Change add_all argument for include_types
ewianda Nov 23, 2024
c63176c
Remove binary wheels and add internal_dev_deps
ewianda Nov 25, 2024
c6f69c2
Add manifest with type example
ewianda Nov 25, 2024
d1f8b9e
Add documentation and update change log
ewianda Dec 7, 2024
8a90f5b
Update requirements on windows
ewianda Dec 8, 2024
067e242
Add an empty line to changelog.
aignas Dec 8, 2024
9577834
Update gazelle/README.md whitespace
aignas Dec 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change add_all argument for include_types
  • Loading branch information
@ewianda
ewianda committed Dec 7, 2024
commit a4fa177bbbc0b553ed7b30ebbf34776b4b684f7a
2 changes: 1 addition & 1 deletion gazelle/modules_mapping/def.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ def _modules_mapping_impl(ctx):
transitive = [dep[DefaultInfo].files for dep in ctx.attr.wheels] + [dep[DefaultInfo].data_runfiles.files for dep in ctx.attr.wheels],
)
args.add("--output_file", modules_mapping.path)
args.add("--include_stub_packages", ctx.attr.include_stub_packages)
args.add_all("--exclude_patterns", ctx.attr.exclude_patterns)
args.add_all("--include_stub_packages", ctx.attr.include_stub_packages)
args.add_all("--wheels", [whl.path for whl in all_wheels.to_list()])
ctx.actions.run(
inputs = all_wheels.to_list(),
Expand Down