fix: Warn only when all SHAs fail to match a requirement #2922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanpenner
changed the title
stefanpenner
changed the title
stefanpenner
force-pushed
the
fix-missing-requirement-warning
branch
from
7238ba3 to
7eb4977
Compare
aignas
reviewed
May 21, 2025
| @@ -334,8 +334,8 @@ def _add_dists(*, requirement, index_urls, logger = None): | |||
| sdist = maybe_sdist | |||
| continue | |||
|
|
|||
| if logger: | |||
| logger.warn(lambda: "Could not find a whl or an sdist with sha256={}".format(sha256)) | |||
| if logger and (len(whls) == 0 and sdist == None): | |||
There was a problem hiding this comment.
The vars are undefined here. What is that you are trying to achieve?
There was a problem hiding this comment.
The vars are undefined here.
@aignas maybe I'm missing something, but whls & sdist appear to be defined at:
There was a problem hiding this comment.
Oh sha256 in the log call isn't defined, let me fix that.
There was a problem hiding this comment.
Ah sorry, somehow I missed it.
However, the intention of the check though was to tell the users that something is wrong andthat the lock file contains hashes that we could not find on the index.
What would be the use case where such behaviour is not desired?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the missing requirement logging is over reporting when a requirement has multiple SHAS and not all match.
That being said, It's possible I'm misunderstanding and this warning is working as intended.