Update compability_level in MODULE.bazel #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
reviewed
Mar 14, 2024
| @@ -15,7 +15,7 @@ | |||
| module( | |||
| name = "toolchains_llvm", | |||
| version = "0.0.0", | |||
| compatibility_level = 0, | |||
| compatibility_level = 1, | |||
There was a problem hiding this comment.
Did we actually break any core API usage with recent changes? If not, I would recommend not bumping this. It certainly doesn't have to be in sync with the major version number unless we expect a large fraction of our users to be broken by an update.
There was a problem hiding this comment.
Thanks. Will revert.
siddharthab
added a commit
that referenced
this pull request
Mar 14, 2024
This reverts commit 8301a10.
siddharthab
added a commit
that referenced
this pull request
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.