Fix tests compatibility with recent async-http versions #1109
+15
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent versions of async-http (and its sub-libraries like request-http) are strict about content-length header: - Get requests should not have any content-length request header provided - POST requests with the body and all responses with stringio body have the content-length header appended automagically
Owner
|
You're on fire with these PRs @misdoro! Thanks for all the work on improving WebMock 👍 |
Contributor
|
FYI, I see that this was released but I don't see the bump commit anywhere in the main branch: 56cb661 |
Owner
|
@Earlopain thank you! Just pushed it. |
Contributor
Author
|
@bblimke it was the last one 😅 , I won't bother you any more 👼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since socketry/protocol-http#84 (protocol-http 0.51.0), internal dependency of async-http gem
the tests were failing complaining about a duplicate
content-lengthheader.CI: allow running tests on all push events, useful for running tests before opening a PR
Follow-up of #1107