OpenPGP: Mitigate some RuntimeExceptions uncovered using Fuzzing #2123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…9/Ed448 signatures
This is a dedicated exception type that is thrown for malformed OpenPGP packets
…algorithm as MalformedPacketException
…edPacketException for malformed packets with unexpected kdf parameter length
…known AEAD algorithms as IOException
… subpacket encoding length to max 5mb
…alformedPacketExceptions
…ng subpacket parsing as MalformedPacketException
…rmed fingerprint lengths as MalformedPacketException
…malformed packets with negative IV
…known AEAD algorithm as MalformedPacketException
…nction in ECDHPublicBCPGKey) as MalformedPacketException
…dDetectionCodePacket
|
Hi @vanitasvitae, Regarding the UserAttributeSubpacketInputStream.MAX_LEN setting (currently 5MB):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
I did run junit-jazzer agains some PGPainless functions and uncovered some bugs in the bcpg codebase.
The commits in this PR harmonize the way malformed or strange packets are handled, by preventing runtime exceptions, such as IndexOutOfBounds, NegativeArraySize, IllegalArgumentExceptions and OutOfMemory errors.
I'm only just getting started with fuzzing, but I can highly recommend it!