Skip to content
This repository was archived by the owner on Aug 7, 2024. It is now read-only.

Adding api methods for suggestions and suggestions/:slug #254

Merged
merged 7 commits into from
Nov 14, 2015

Conversation

trentstollery
Copy link

Hey!

So I needed these endpoints for a project I'm working on at work so I thought I would add them :)
Follows your normal layout and I added some classes too.
Works like a charm :)
Happy to clean up/Add any more doco so we can merge it back in just let me know.
It's been kind of a rushed job since I needed it to work asap haha.
Thanks for your lib it rocks!!

@@ -29,7 +29,7 @@ def read(*paths):

setup(
name='python-twitter',
version='2.3',
version='2.3.1',
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just my idea for the version jump... not sure if you use this sort of versioning but it maybe sane for such a small jump like this

@bear
Copy link
Owner

bear commented Nov 9, 2015

we do use patch levels, but the 2.3 is already a jump for a larger change -- so no need to bump it IMO

@trentstollery
Copy link
Author

I agree with the version issue, I've swapped this back to 2.3 :)

@trentstollery
Copy link
Author

I also required the media data from a tweet. So I've added a commit to add that to a class :).
I think you where half way to doing that but I thought I would finish it up!

@bear
Copy link
Owner

bear commented Nov 14, 2015

I need to fix the travis config to not test on python v3 until the python v3 branch is live...

long winded way of saying that i'm going to merge this - thanks for the PR!

bear added a commit that referenced this pull request Nov 14, 2015
Adding api methods for suggestions and suggestions/:slug
@bear bear merged commit 14cc046 into bear:master Nov 14, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants