Skip to content

Create directories for hdfs #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2016

Conversation

jacobtomlinson
Copy link
Contributor

Directories specified in hdfs-site.xml do not exist and do not appear to be created automatically.

This PR add the creation of those directories to the Dockerfile and closes #30.

@mikefaille
Copy link
Member

lgtm

cc : @davidonlaptop

@davidonlaptop
Copy link
Member

LGTM too. I just think we should probably do it before the namenode format
command. What do you think?

On Wed, Feb 24, 2016 at 3:30 AM, mikefaille [email protected]
wrote:

lgtm

cc : @davidonlaptop https://github.com/davidonlaptop


Reply to this email directly or view it on GitHub
#31 (comment)
.

@mikefaille
Copy link
Member

@jacobtomlinson To put you in context : #25

@jacobtomlinson
Copy link
Contributor Author

Ok I've moved it up.

I also removed the creation of /data as it is superseded by this command having the -p option.

Edit
I see you already said replace the mkdir call on line 40 so there was no need for me to explain why I removed the creation of /data 😄.

@davidonlaptop
Copy link
Member

haha, i know I shouldn't have left a similar comment both at the pull request and line comment.

LGTM.

davidonlaptop added a commit that referenced this pull request Feb 25, 2016
Fixing issue #30 with error "Storage directory /data/dfs/name does not exist" on Docker 1.9.1 on EC2.
@davidonlaptop davidonlaptop merged commit bfae4bd into bigdatafoundation:master Feb 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error running name node
3 participants