Base58 test cleanup and extracted vectors #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcousens
changed the title
dcousens
changed the title
|
+1 |
kyledrake
added a commit
that referenced
this pull request
Apr 21, 2014
Base58 test cleanup and extracted vectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request extracts the test vectors out of
test/base58.jsandtest/base58check.jsand puts them insidetest/fixtures.This extraction of the test vectors should allow for easier verification against test integrity with the reference client tests: https://github.com/bitcoin/bitcoin/blob/master/src/test/data/base58_encode_decode.json, https://github.com/bitcoin/bitcoin/blob/master/src/test/data/base58_keys_valid.json and https://github.com/bitcoin/bitcoin/blob/master/src/test/data/base58_keys_invalid.json.
This pull request also fixes a minor bug in the
Addresstests which were not properly testing against the malformed data.Lastly, the
Addresstests now verify against the same malformed base58 as thebase58tests.This is arguably a demonstration of how lightweight the
Address.fromBase58Checkwrapper really is, but I couldn't think of a reason why they shouldn't share the same invalid test vectors.