[PSBT] Allow nonWitnessUtxo with segwit #1461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Also, the reason why we should allow this is that segwit needs less info, but nonWitnessUtxo has more info, so why reject it when we can sign it? This way wallet apps could decide to code it so that all inputs have nonWitnessUtxo just in case... or if they don't know what the redeemscript of a P2SH prevoutScript is they can just err on the side of caution and stick the nonWitnessUtxo in it. |
junderw
changed the title
d-yokoi
approved these changes
Aug 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes a bug.
One fixture for finalizeAllInputs only had a finalScriptSig when it should have also had a finalWitnessScript...
strangely, we test the same script in the integration tests, but the integration tests passed.... ????
This fails currently, and needs a bip174 fix upstream to allow for this.