Remove const and replace with var
#502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To keep the project consistenly ES5. Source: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/const
Contributor
|
Thanks @alex-seville, beat me to it 👍 |
Contributor
Author
|
Checks failed? |
Contributor
|
Unrelated, restarting the failed jobs now. The faucet we use on testnet seems to periodically fail. |
Contributor
Author
|
ok, I'll leave it in your capable hands. thanks for using blanket! |
Contributor
|
@jprichardson I'm temporarily disabling status checks required to merge, as the issue stopping this from passing is external to the library, and I can't actually continue to resolve that without this fix without wasting a lot of time. |
dcousens
added a commit
that referenced
this pull request
Nov 19, 2015
Remove `const` and replace with `var`
Member
|
@dcousens seems reasonable enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To keep the project consistenly ES5.
Source: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/const