Adding some checks on deriving indexes #539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (index >= highestIndex) { | ||
| throw new Error('Could not derive with too high index') | ||
| } | ||
|
|
There was a problem hiding this comment.
I have to say I don't understand typeforce that much, but it seems it's actually pretty easy to do that in there. How do you want to name the types... UnsignedInt31 and UnsignedInt32? :) (can typeforce right now to check if the number is integer by the way?)
There was a problem hiding this comment.
also would you want these types to be added into typeforce source directly, or rather somewhere in bitcoin.js?
There was a problem hiding this comment.
...oh, it seems you actually do have the types already in bitcoinjs (well not the 31 bit one, but that can be added). OK, will use that instead
As a consequence, it will not allow accidentally double-hardened indexes. It also won't allow strings or forgotten parameters.
|
yep you were right, it's easier with typeforce types |
karelbilek
changed the title
dcousens
added a commit
that referenced
this pull request
Feb 7, 2016
Adding some checks on deriving indexes
|
Nice @Runn1ng 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added some checks on hardening indexes.
You don't want to accidentally put in twice hardened index, or a negative number to harden (which produces non-hardened index), etc.