Fix market symbol split regexp. #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently code fails with asset names containing numbers like `BTS:BTSBOTS.S1`. In the ASCII table, between '/' and ':' there is all the digits... ``` _get_assets_from_string(`BTS:BTSBOTS.S1`) = ['BTS', 'BTSBOTS.S', ''] ```
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
=======================================
Coverage 46.16% 46.16%
=======================================
Files 38 38
Lines 3009 3009
=======================================
Hits 1389 1389
Misses 1620 1620Continue to review full report at Codecov.
|
|
Thanks for the fix! |
SmileyChris
added a commit
to SmileyChris/python-bitshares
that referenced
this pull request
Dec 22, 2017
SmileyChris
added a commit
to SmileyChris/python-bitshares
that referenced
this pull request
Dec 22, 2017
SmileyChris
added a commit
to SmileyChris/python-bitshares
that referenced
this pull request
Dec 22, 2017
xeroc
added a commit
that referenced
this pull request
Jan 19, 2018
Complete fix for market symbol split (started in #8)
xeroc
added a commit
that referenced
this pull request
Jan 19, 2018
Release 0.1.10 4c81df4 (HEAD -> master) Merge branch 'release/0.1.10' 6922bed (release/0.1.10) version bump 7edc452 (develop) fix test fa9b1f4 (origin/develop) fix #21 c4e86a7 Fix #11 0861d9d Merge pull request #24 from SmileyChris/symbol_split 5d68b2d Merge branch 'develop' into symbol_split 8c3a548 close #27 c526fe7 close #18 d87b583 Merge pull request #31 from BroncoTc/BroncoTc-patch-1 0a85d8a close #33 7d590c0 Fix #36 abada9f [wallet] locked() returns False if there are keys preloaded d8dcc7b Reserve from proper account d501936 [setup] dependency of graphenelib pushed by one release 344f27a minor cleanup 7724362 [message] minor fixes to self calls ce470e3 [message] setup separate class for message signing e46c357 [txbuilder] do not raise exception if key not found 85f46cd [message] initial message signing support d4332e0 [block] Block Header for easier access to time etc. 08376c9 fix apt command error 1c2b842 Merge tag '0.1.9' into develop 84d7cd9 Complete fix for market symbol split (started in #8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue with asset names containing numbers like
BTS:BTSBOTS.S1.In the ASCII table, between '/' and ':' there is all the digits...