Enhance search #75
Merged
Enhance search #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved JSON feed file to `packages.json` - Added `json_path` to Jekyll configuration for new JSON feed - Added `search_path` to Jekyll configuration for search page - Updated JavaScript search to point to new JSON feed - Updated default template to utilize configured variables for navigation links
- Modified JavaScript search into module - Moved JavaScript to module directory - Updated search page to import JavaScript module and provide configuration object
- Updated search JavaScript with templates for results, zero results, and no query - Updated search page with templates configuration and templates - Updated custom style sheet to modify search view
- Updated search JavaScript with Fuse fuzzy search module and associated code - Updated search page results template to include additional details - Updated custom style sheet to add highlight rules - Updated JSON feed to simplify package URLs
- Updated search JavaScript with HotKeys keybindings module and associated code - Updated search page keybinding configuration - Updated custom style sheet to add selection rule
jwerle
approved these changes
Apr 15, 2023
Potherca
approved these changes
Apr 21, 2023
- Correcting strict-type comparison - Moved ternary operators to beginning of lines - Added braces to all if flow blocks
- Added `catch` in `_fetchFeed` function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following PR #74, I've provided enhancements to the search functionality:
This code has been tested on both FireFox and Chrome (on Linux).
The search field is auto-focused upon the search page loading. Search is performed 1/4 second after query change (can be easily adjusted in source). Query allows for "advanced search" capabilities. Fuzzy search matches are highlighted in results. Keyboard shortcuts are provided for:
ctrl+s,control+s,s, or/downupenterResult navigation keybindings also work from within the search field.