Skip to content

Add bashunit #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Add bashunit #82

merged 3 commits into from
Sep 22, 2023

Conversation

Chemaclass
Copy link
Contributor

Description

I followed the instructions from https://bpkg.sh/submit/ to submit adding bashunit to bpkg

Screenshot 2023-09-11 at 21 31 06

@samlikins
Copy link
Member

@Chemaclass, that sounds like a good project to add. I noticed that the link in the description to the project (ie: Chemaclass/bashunit) isn't valid and the link at the bottom of the file you're submitting doesn't have a bpkg.json file. We'd love to have this project listed, but it will require this file to be in the project root for the utility to manage the project on installing systems. Even without publishing the project on BPKG.sh, having this file allows the BPKG utility to install the project.

Once the file has been added to bashunit update us and I can make sure everything is good to merge.

On a side note, I've been using shUnit2, and have been trying to get them to accept a PR for a BPKG package file I created, and it's been months without success; so thank you for your efforts!

@Chemaclass
Copy link
Contributor Author

Chemaclass commented Sep 15, 2023

Hey @samlikins! I created a bpkg.json here: TypedDevs/bashunit#90, can you please check this out and let me know if we should apply any changes to that PR?

Regarding the the link to the project, we migrated the repo from Chemaclass/bashunit to TypedDevs/bashunit because it is not just me the person behind, but also @Tito-Kati and @khru. I updated the GitHub link in this PR changes as well.

@samlikins
Copy link
Member

@Chemaclass, it looks good. Let me know when you've had a chance to test it out and are ready for this addition to be merged.

@Chemaclass
Copy link
Contributor Author

Chemaclass commented Sep 22, 2023

@samlikins thanks! Yes, let's merge this PR 🚀 We have the bpkg.json file.

@samlikins samlikins merged commit 596954f into bpkg:master Sep 22, 2023
@Chemaclass Chemaclass deleted the bashunit branch September 22, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants