Add possibility to dynamically include script parameter section

[bugy]

There should be a possibility to add an "include" section to a script configuration, which would add/fill parameters configuration from another file.
This "include" section can depend on current parameter values, so it will be loaded dynamically while user selects values on UI

There are 2 use cases behind:

1. Sharing parameters in different configurations
2. Depending on some parameter, we could include different corresponding additional parameters

For more details and reasoning please read comments in #119

[bugy]

@yosefy, I've completed this feature. There is a new field include in script configuration section. This could be a static path (e.g. '/home/myuser/included.json') or a dynamic path ('/home/myuser/${parameter name}.json').
If the path is relative, then it will be relative to conf/runners folder.

Included configurations have the same structure as normal configurations. Though only parameters section is supported at the moment (other fields are undocumented/unsupported, so please don't use them).

To avoid loading included files as a standalone configurations, there is a possibility to exclude them with a new field hidden. Any hidden configurations will not be shown to a user and can only be included.

If both base configuration and included configuraition have a parameter with the same name, then included parameter will be ignored.

Example included file (see parameterized.json and included.json from samples for more details):

{
  "hidden": true,
  "parameters": [
    {
      "name": "inc_param1",
      "type": "int"
    },
    {
      "name": "inc_param2",
      "no_value": "true",
      "param": "--inc2"
    }
  ]
}

To support this I had to completely reimplement communication layer when loading script config and starting execution, so it could cause some bugs :(

[yosefy]

thanks a lot!

…

On Sat, Oct 27, 2018 at 12:27 AM Iaroslav Shepilov ***@***.***> wrote: @yosefy <https://github.com/yosefy>, I've completed this feature. There is a new field include in script configuration section. This could be a static path (e.g. '/home/myuser/included.json') or a dynamic path ('/home/myuser/${parameter name}.json'). If the path is relative, then it will be relative to conf/runners folder. Included configurations have the same structure as normal configurations. Though only parameters section is supported at the moment (other fields are undocumented/unsupported, so please don't use them). To avoid loading included files as a standalone configurations, there is a possibility to exclude them with a new field hidden. Any hidden configurations will not be shown to a user and can only be included. If both base configuration and included configuraition have a parameter with the same name, then included parameter will be ignored. Example included file (see parameterized.json and included.json from samples <https://github.com/bugy/script-server/tree/master/samples/configs> for more details): { "hidden": true, "parameters": [ { "name": "inc_param1", "type": "int" }, { "name": "inc_param2", "no_value": "true", "param": "--inc2" } ] } To support this I had to completely reimplement communication layer when loading script config and starting execution, so it could cause some bugs :( — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#133 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMVy7dGnXADDwlL0_gYfIiQ_9F3vKW9zks5uo34rgaJpZM4W7c_G> .

[yosefy]

sorry just a question, so i cant use values from included file in script?
so how to use it?

[bugy]

Hi, what do you mean?

[yosefy]

i dont see values form included when echo $@

…

On Mon, Feb 25, 2019 at 2:59 PM Iaroslav Shepilov ***@***.***> wrote: Hi, what do you mean? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#133 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMVy7QKpAysd1HPrePzHeWqPvQ260E7wks5vQ948gaJpZM4W7c_G> .

[bugy]

That's extremely strange. Do you see these values on UI? And in the log, before script is called? (or after, in the admin page)

[yosefy]

{
"hidden": false,
"parameters": [
{
"name": "inc_param1",
"type": "list",
"values": [
"aaa",
"bbb"
]
},
{
"name": "inc_param2",
"no_value": "true",
"param": "--inc2"
}
]
}

script is:

args=("$@")
echo $@

[bugy]

Ok, apparently it doesn't work at all :( Will fix it

[yosefy]

@bugy , do you have some estimation of fixing it
blocking from putting in prod :)

thanks