Skip to content

Conversation

miksir
Copy link

@miksir miksir commented Jun 4, 2020

secret_storage_file option for move secure cookie key file. Otherwise cookie reseted on docker container recreation.

@bugy
Copy link
Owner

bugy commented Jun 5, 2020

Hi @miksir thanks for your changes, they definitely make sense!
But what do you think about configuring the whole temp folder instead? I think it would be more flexible/helpful

@miksir
Copy link
Author

miksir commented Jun 5, 2020

IMHO no. TEMP folder is for temporary files which is safe to delete. Temporary files should not change application behavior if removed. But files with any kind of state - it's not temporary file. In point of linux directories view - it's or /etc (config) or /var. IMHO it's much closer to config, many frameworks even has config option "secret key" for hmac signing.

@bugy
Copy link
Owner

bugy commented Jun 5, 2020

Hmm, maybe Script server should store the secret file in the config folder then?

@miksir
Copy link
Author

miksir commented Jun 5, 2020

May be :) as for me - separate path is better because conf folder mounted as ro volume to container

@bugy
Copy link
Owner

bugy commented Jun 5, 2020

ok :)

@bugy bugy merged commit 42b7898 into bugy:master Jun 5, 2020
@bugy bugy added this to the 1.16.0 milestone Jun 6, 2020
@miksir miksir deleted the secret_storage_file branch June 11, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants