Skip to content

Conversation

@yoshuawuyts
Copy link
Member

@yoshuawuyts yoshuawuyts commented Jun 8, 2024

Closes #880. Filing as a draft PR because I haven't yet run the tests locally. Yay, tests pass!

As a neat side-effect: this should enable people to use the rust docker images to build projects using cargo-component. Those images don't come with either rustfmt or rustup pre-installed, so wit-bindgen depending on rustfmt can actually be inconvenient in surprising ways. This PR should (hopefully) fix that!

@yoshuawuyts yoshuawuyts marked this pull request as ready for review June 9, 2024 00:42
Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexcrichton alexcrichton added this pull request to the merge queue Jun 9, 2024
Merged via the queue into bytecodealliance:main with commit 58ade72 Jun 9, 2024
@yoshuawuyts yoshuawuyts deleted the prettyplease branch June 9, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

replace cargo fmt with the prettyplease crate

2 participants