Added config option to specify custom seeder template path to use #2146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dereuromark
reviewed
Nov 23, 2022
dereuromark
reviewed
Nov 23, 2022
dereuromark
reviewed
Nov 23, 2022
dereuromark
reviewed
Nov 23, 2022
Fixing Code-Review problems Co-authored-by: Mark Scherer <[email protected]>
|
@dereuromark Hello Mark! How are You? Could You please accept the pull-request? :) |
|
I already looked at it, would be nice if someone else also looks at it |
othercorey
reviewed
Nov 25, 2022
|
By the way, I'm not sure how github and the setup of this project works, but I made a lot of commits like "fix review problems", so is it possible to sqaush it in a single commit to get rid of this junk? Will it be done automatically my accepting the pull-request or should I do something? |
SunriseCoder
requested review from
othercorey and
dereuromark
and removed request for
dereuromark and
othercorey
|
No worries, squash merge is fixing it |
othercorey
approved these changes
Nov 25, 2022
|
@dereuromark @othercorey |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Just finished work for the following issue: Custom Seed Template from Config #2145
Could anyone please make code review and accept or give me feedback to fix it?
Thank You very very much :)