Skip to content

Use kvm address in producer selection #1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 13, 2020

Conversation

Xela101
Copy link

@Xela101 Xela101 commented Aug 6, 2020

New Pull Request Submissions:

  1. Have you followed the guidelines in our Contributing document?
  2. Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  3. I have added tests to cover my changes.
  4. All new and existing tests passed.
  5. Have you lint your code locally prior to submission?
  6. Does your code follows the code style of this project?
  7. Does your change require a change to the documentation.
    • I have updated the documentation accordingly.
  8. Have you added an explanation of what your changes do and why you'd like us to include them?
  9. Have you inserted a keyword and link to the issues the PR closes in its descriptions (ex closes #1) ?
  10. Is you branch up to date, have you integrated all the latest changes from develop and resolved conflicts ?
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Enhancement
  • What is the current behavior? (You can also link to an open issue here)
    Catalyst uses PubKey and its not compatible for Smart Contract validators
  • What is the new behavior (if this is a feature change)?
    Use KvmAddress instead of PubKey for Smart Contract validators
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No
  • Other information:

@Xela101 Xela101 changed the base branch from master to develop August 6, 2020 13:52
@Xela101 Xela101 marked this pull request as ready for review August 7, 2020 09:02
stxphxn
stxphxn previously approved these changes Aug 7, 2020
Copy link
Member

@stxphxn stxphxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Xela101 Xela101 self-assigned this Aug 7, 2020
@Xela101 Xela101 added the Enhancement 👷 New feature or request label Aug 7, 2020
@Xela101 Xela101 added this to the Full Consensus Sprint 9 milestone Aug 7, 2020
@sudhirtibrewal sudhirtibrewal merged commit 923d739 into develop Aug 13, 2020
@sudhirtibrewal sudhirtibrewal deleted the use-kvm-address-in-producer-selection branch August 13, 2020 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement 👷 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants