-
Notifications
You must be signed in to change notification settings - Fork 0
feature: Ecrypted Submission Responses #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment but what would you think of moving the utilTokenGeneration.mjs
script into the utils
folder.
I was going to remove it completely later on since the same functionality can now be achieved through the |
@patheard the code base is also going to go through a refactor where the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work :)
There are probably a lot of comments that you may want to ignore either because I missed the point or because you just want to tackle those during our first refactoring session.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on my end - nicely done on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Good job :)
Summary | Résumé
Main Features:
aes-256-gcm
by getting the Public key from the Web App database and returns the encrypted values. The public key is cached for a 5 minute period to reduce the calls required to the database./utils
that demonstrates how to request an access token by using the private key and the resulting access token to retrieve a particular response. Once we have the/new
endpoint finalized we can modify the script to not ask for the response Name to retrieve.Medium sized Additions to project:
.js
extention of all of our relative module imports.Small Additions to project:
logMessage()
is now available like the web app from@lib/logger.js
watch
functionality of tsx.Test instructions | Instructions pour tester la modification
Create some responses in the vault and retrieve them using
pnpm retrieve
from the utils folder.