allow viewport to wrap lines #87
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IllusionMan1212
force-pushed
the
viewport-wrap
branch
from
5c7a0b5 to
23842ea
Compare
bashbunni
approved these changes
Oct 19, 2022
Member
|
In order for this to be merged text will need to be to reflowed (that is, re-wrapped) on resize. We'll want to pay special attention to how both the active line and viewport position is maintained, as best as possible, post-resize/re-wrap. Additionally, I'd prefer to wait to merge this feature until muesli/reflow#43 is fixed upstream so as to mitigate duplicate reports on that issue in this repo. |
Member
|
this should be fixed on main/v2-exp! thanks for the PR though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #56 (partially? not sure about the truncation part).
Lines should wrap according to the width of the viewport. resizes can be handled by the user easily by updating the viewport width when
tea.WindowSizeMsgis fired.