Skip to content

refactor: rewrite segment helpers to ts #11122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
+77 −68
Open

refactor: rewrite segment helpers to ts #11122

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
eb23570
feat: add some types to helpers.segment.ts
Arantiryo Jan 18, 2023
011dbea
feat: add more types
Arantiryo Jan 27, 2023
03f001d
fix: _chart type
Arantiryo Jan 30, 2023
5019c3f
feat: add getContext() type
Arantiryo Jan 30, 2023
04bb3bd
feat: add types to helpers.canvas.ts
Arantiryo Jan 30, 2023
288a525
Revert "feat: add types to helpers.canvas.ts"
Arantiryo Feb 3, 2023
22a87c8
refactor: move SegmentStyle into a separate interface
Arantiryo Feb 3, 2023
71e1bc1
refactor: move 'Bounds' to the types file, rename to 'SegmentBounds'
Arantiryo Feb 6, 2023
a6ea376
refactor: remove jsdoc types
Arantiryo Feb 7, 2023
ff37d78
Revert "refactor: remove jsdoc types"
Arantiryo Feb 7, 2023
e220519
refactor: remove jsdoc types but keep the descriptions
Arantiryo Feb 7, 2023
88f12c2
refactor: remove jsdoc return types for Segment
Arantiryo Feb 7, 2023
f515365
fix: lint errors
Arantiryo Feb 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: _chart type
  • Loading branch information
@Arantiryo
Arantiryo committed Jan 30, 2023
commit 03f001d55a8edd4e931844342e1e4c8ffb816ddb
2 changes: 1 addition & 1 deletion src/types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1819,7 +1819,7 @@ export interface LineElement<T extends LineProps = LineProps, O extends LineOpti
_loop: boolean;
_fullLoop: boolean;
_datasetIndex: number;
_chart: AnyObject;
_chart: Chart;
}

export declare const LineElement: ChartComponent & {
Expand Down