Revert "Try enabling using cmake for LNT automation testing. (#315)" #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopelsunce
pushed a commit
to dopelsunce/checkedc-clang
that referenced
this pull request
Sep 28, 2020
Fixes installation issue with checked headers in subfolders. Checked headers not in the top-level directory in the source (e.g. arpa/inet_checked.h) were being copied to the top-level directory in the installation. This fixes that issue. Specifically, the directory structure was sucessfully preserved when copying the checked headers into the build directory, but then subfolders were being removed from the path when copying from the build directory into the install directory. I am still not sure exactly why, but the documentation is clear that using DIRECTORY instead of FILES in the install will solve the problem and preserve directory structure. Tested in Linux (sudo make install).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit eefccde.
It turns out that using cmake for LNT automation testing is more complex than I thought. It apparently requires the LLVM gold plugin to be built too. Revert this for now until this is sorted out.