build release compilers for Windows properly in automation #495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtarditi
changed the title
dtarditi
added a commit
that referenced
this pull request
Jun 8, 2018
This updates the documentation to describe how to build release builds on Windows, matching #495. It also: - fixes some typos in the existing documentation for setup and build. - switches from VS 2015 to VS 2017 in the description of selecting a cmake generator.
sulekhark
pushed a commit
that referenced
this pull request
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the build automation scripts for Windows to actually build release versions of clang. We were relying on CMAKE_BUILD_TYPE, which is disregarded when cmake generates a build system for Visual Studio. The fix is to pass the build type in as an additional parameter to the msbuild invocations instead.
This addresses issue #494, where the installed compiler required a debug version of the Windows CRT that isn't usually installed on Windows systems.
Testing: