Skip to content

Correctly determine bounds for predefined literals #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 14, 2019
Merged

Correctly determine bounds for predefined literals #673

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7d165ad
Correctly determine bounds for predefined literals
Aug 22, 2019
a268dc8
Make some vars const
Aug 23, 2019
421db65
Add simple test case
Aug 24, 2019
bd4b6e8
Add more tests
Aug 26, 2019
9284855
Bind string literal to temporary expr
Aug 27, 2019
e6ada3e
Capitalize function name
Aug 28, 2019
1330739
Remove extra braces
Aug 28, 2019
7c2ad31
Handled subscripting of predefined literals
Sep 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Capitalize function name
  • Loading branch information
Mandeep Singh Grang committed Aug 28, 2019
commit e6ada3e033aae6dd3e01bd628753c246ea793acf
6 changes: 3 additions & 3 deletions lib/Sema/SemaBounds.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -760,7 +760,7 @@ namespace {
}

// Infer bounds for string literals.
BoundsExpr *inferBoundsForStringLiteral(Expr *E, StringLiteral *SL,
BoundsExpr *InferBoundsForStringLiteral(Expr *E, StringLiteral *SL,
CHKCBindTemporaryExpr *Binding) {
// Use the number of characters in the string (excluding the null
// terminator) to calcaulte size. Don't use the array type of the
Expand Down Expand Up @@ -918,7 +918,7 @@ namespace {
ArrLValue);
return ExpandToRange(Base, BE);
} else if (StringLiteral *SL = dyn_cast<StringLiteral>(SE)) {
return inferBoundsForStringLiteral(E, SL, Binding);
return InferBoundsForStringLiteral(E, SL, Binding);
} else
return CreateBoundsAlwaysUnknown();
}
Expand All @@ -929,7 +929,7 @@ namespace {
if (!SL)
return CreateBoundsAlwaysUnknown();
auto *Binding = new (Context) CHKCBindTemporaryExpr(E);
return inferBoundsForStringLiteral(E, SL, Binding);
return InferBoundsForStringLiteral(E, SL, Binding);
}
default:
return CreateBoundsAlwaysUnknown();
Expand Down