Skip to content

Add checked information for function declarations to AST reading and writing #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 12, 2019

Conversation

kkjeer
Copy link
Contributor

@kkjeer kkjeer commented Nov 8, 2019

(See issue #704)
Add the checked scope specifier and written checked scope specifier for function declarations to AST reading and writing, similar to the work done in #716 for compound statements. Follow-up work: move pch tests to a subdirectory (#719).

Testing:

  • Modified ast-dump-pch tests to include tests for checked scope information for function declarations.
  • Passed manual testing on Windows.
  • Passed automated testing on Windows and Linux.

@kkjeer kkjeer requested review from dtarditi and mgrang November 8, 2019 21:53
Copy link
Member

@dtarditi dtarditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants