Skip to content

Remove admins from white list on commit validation  #12717

@romani

Description

@romani

https://github.com/checkstyle/checkstyle/actions/runs/4076473411/jobs/7024253795#step:4:121

Commit:
Issue 12705: remove .m2 for codenarc execution to make it more stable

Symbol # is missing.
Missed validation due to

Arrays.asList("Roman Ivanov", "rnveach", "dependabot[bot]");

It was fine for long time, but now, as all automated, all should follow rules. Admins always have all permissions to skip CI and brutal action if required, so better for now for all to follow. Admins should be removed fr this list.

Exception:

Exception in thread "main" java.lang.NumberFormatException: For input string: "Issue 12705"
	at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
	at java.base/java.lang.Integer.parseInt(Integer.java:652)
	at java.base/java.lang.Integer.parseInt(Integer.java:770)
	at com.github.checkstyle.github.CommitMessage.getIssueNumber(CommitMessage.java:81)

Additionally, we should fallback release notes categories to "misc" if something is wrong with parsing a format, we need to update release notes generator.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions