Google style: method names should not allow to have '_' unless they are annotated by Test

[romani]

detected at #15411 (comment)

this 0eadd97 is where _ is explicitly disappear and becomes covered by \w.

but it make all methods to be allow to have _

in style guide:

5.2.3 Method names
Method names are written in lowerCamelCase.
Method names are typically verbs or verb phrases. For example, sendMessage or stop.
Underscores may appear in JUnit test method names to separate logical components of the name, with each component written in lowerCamelCase, for example transferMoney_deductsFromSource. There is no One Correct Way to name test methods.

attention to Underscores may appear in JUnit test method names to separate logical components of the name,

Required: use https://checkstyle.org/filters/suppressionxpathsinglefilter.html
https://checkstyle.org/filters/suppressionsinglefilter.html#SuppressionSingleFilter to suppress

[Zopsss]

@romani how can we detect Test methods? There's no way to check annotations in your suggested suppression.

Can we use https://checkstyle.sourceforge.io/filters/suppressionxpathfilter.html?

It allows us to suppress violation by filtering annotations, Example from documentation:

https://checkstyle.sourceforge.io/filters/suppressionxpathfilter.html#Examples

Next example is about suppressing method with certain annotation by its name and element value.

public class InputTest {
    @Generated("first") // should not be suppressed
    public void test1() {
    }

    @Generated("second") // should be suppressed
    public void test2() {
    }
}

Suppression:

<suppress-xpath checks="." query="//METHOD_DEF[
            .//ANNOTATION/IDENT[@text='Generated']]"/>

We can use this suppression. But the catch is that it will completely ignore test methods for MethodName check while we only want to allow for _, we dont want to completely ignore test methods.

[romani]

https://checkstyle.org/filters/suppressionxpathsinglefilter.html is able to do what we need:

• match by xpath
• if check name is what we need
• if message is what we need.

<module name="SuppressionXpathSingleFilter">
<property name="query" value="....."/>
<property name="checks" value="MethodNameCheck"/>
    <property name="message" value=".*_.*"/>
  </module>

[romani]

@Zopsss, I updated comment to be more correct

[Zopsss]

<property name="query" value="....."/>

Can you suggest the query to be used? I tried different xpath queries but didn't found any useful ones

[romani]

this is example for method name - https://stackoverflow.com/a/75069873
you need to update it to make it for annotation of method.

here is example with annotation - https://stackoverflow.com/a/68138470