Re-enable no-error-pmd build

[mahfouz72]

We dropped the no-error-pmd build because there were failures due to #15376.
We should re enable this build when PMD merge the PR that uses the new property to fix the violations. The PR can't be merged until checkstyle new release.
PMD PR: pmd/build-tools#33

build failure URL: https://app.circleci.com/pipelines/github/checkstyle/checkstyle/27241/workflows/ae4881cd-8f64-4245-a7c0-619e023f8e5e/jobs/662368

There are 8 errors reported by Checkstyle 10.18.0-SNAPSHOT with /net/sourceforge/pmd/pmd-checkstyle-config.xml ruleset.
[ERROR] src/main/java/net/sourceforge/pmd/lang/java/ast/ConstantFolder.java:[24,7] (modifier) RedundantModifier: Redundant 'strictfp' modifier.
[ERROR] src/main/java/net/sourceforge/pmd/lang/java/ast/ConstantFolder.java:[141,12] (modifier) RedundantModifier: Redundant 'strictfp' modifier.
...

[romani]

@mahfouz72, please share a reason why config should be updated.
It looks like it becomes very breaking changes for config, but it suppose to be breaking changes only for behavior of Check, and if users do not use fancy mmodifiers, they should not be affected.

[mahfouz72]

The default value of the property is 21. They should set it to their Java version which is below 17. They use strictfp modifier and it should not be violation because they are below 17.

PMD config

    <module name="RedundantModifier">
      <property name="severity" value="error"/>
      + <property name="jdkVersion" value="8"/>
    </module>

[romani]

Please share violation message, with file where they use it.

[mahfouz72]

[INFO] There are 8 errors reported by Checkstyle 10.18.0-SNAPSHOT with /net/sourceforge/pmd/pmd-checkstyle-config.xml ruleset.
[ERROR] src/main/java/net/sourceforge/pmd/lang/java/ast/ConstantFolder.java:[24,7] (modifier) RedundantModifier: Redundant 'strictfp' modifier.
[ERROR] src/main/java/net/sourceforge/pmd/lang/java/ast/ConstantFolder.java:[141,12] (modifier) RedundantModifier: Redundant 'strictfp' modifier.
[ERROR] src/test/java/net/sourceforge/pmd/lang/java/ast/ConstantExpressionsTests.java:[108,5] (modifier) RedundantModifier: Redundant 'strictfp' modifier.
[ERROR] src/test/java/net/sourceforge/pmd/lang/java/ast/ConstantExpressionsTests.java:[207,5] (modifier) RedundantModifier: Redundant 'strictfp' modifier.
[ERROR] src/test/java/net/sourceforge/pmd/lang/java/ast/ConstantExpressionsTests.java:[247,5] (modifier) RedundantModifier: Redundant 'strictfp' modifier.
[ERROR] src/test/java/net/sourceforge/pmd/lang/java/ast/ConstantExpressionsTests.java:[287,5] (modifier) RedundantModifier: Redundant 'strictfp' modifier.
[ERROR] src/test/java/net/sourceforge/pmd/lang/java/ast/ConstantExpressionsTests.java:[302,5] (modifier) RedundantModifier: Redundant 'strictfp' modifier.
[ERROR] src/test/java/net/sourceforge/pmd/lang/java/ast/ConstantExpressionsTests.java:[319,5] (modifier) RedundantModifier: Redundant 'strictfp' modifier.

[adangel]

@mahfouz72 We've updated PMD, you can enable the "no-error-pmd" validation again.