Witness derivation #31
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseth
force-pushed
the
witness_derivation
branch
from
aaa7a1f to
bdca5ba
Compare
chriseth
force-pushed
the
witness_derivation
branch
from
bdca5ba to
0258d6e
Compare
georgwiese
reviewed
Jul 7, 2023
Comment on lines
+118
to
+119
| \item $n \in \uint$ is called the \emph{number of columns}, | ||
| \item $m \in \uint$ is an integer (usually a power of two), called the \emph{number of rows}, |
There was a problem hiding this comment.
I think usually, the number of rows is denoted with n and the number of columns with m, so I'd change that. Also, later you define matrix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.