Skip to content

Add TLS LB in front of container VM #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Mar 31, 2025
Merged

Add TLS LB in front of container VM #71

merged 14 commits into from
Mar 31, 2025

Conversation

auriaave
Copy link
Contributor

No description provided.

renovate-bot and others added 14 commits March 28, 2025 19:05
@renovate-bot @auriaave
Add renovate.json
7ed1eb9
@renovate-bot @auriaave
chore(deps): update docker.io/library/alpine docker tag to v3.21.3
c9b0774
@renovate-bot @auriaave
chore(deps): update docker.io/library/golang docker tag to v1.24.1
a99f1c0
@renovate-bot @auriaave
fix(deps): update module github.com/palantir/go-githubapp to v0.34.0
36f56d6
@auriaave
Revert "fix(deps): update module github.com/palantir/go-githubapp to …
72273a3 
…v0.34.0"

This reverts commit 36f56d6.
@renovate-bot
fix(deps): update module github.com/palantir/go-githubapp to v0.34.0
9ff7340
@auriaave
go mod tidy vendor verify
dca5a67 
Signed-off-by: Alvaro Uria <[email protected]>
@auriaave
Update go-github v53 to v70
d2a28d4 
Signed-off-by: Alvaro Uria <[email protected]>
@auriaave
go mod tidy vendor verify
eb63530 
Signed-off-by: Alvaro Uria <[email protected]>
@auriaave
Dereference GetRequiredStatusChecks contexts
dc52d27 
Signed-off-by: Alvaro Uria <[email protected]>
@auriaave
Remove Projects (classic), deprecated.
a51d38b 
Signed-off-by: Alvaro Uria <[email protected]>
@auriaave
Merge pull request #14 from auriaave/pr/auriaave/go-124
5464133 
Update from Go 1.21 to 1.24
@auriaave
Add TLS LB in front of container VM
13f2596 
Signed-off-by: Alvaro Uria <[email protected]>
@auriaave
Remove public IP from container VM
e5f3866 
Signed-off-by: Alvaro Uria <[email protected]>
@auriaave auriaave marked this pull request as draft March 31, 2025 07:21
@auriaave
Copy link
Contributor Author

@mhofstetter @aanm please have a look

This change will:

  1. Upgrade the codebase to Go 1.24 and go-github v70 (latest version)
  2. Since GitHub does not support Projects (classic), and go-github v68 removes its support (see feat!: Remove Project (classic) support google/go-github#3380), the code base removes the support to track issues on a GH project - I don't think this is used at present time, so I did not bother to implement ProjectsV2.
  3. Regarding TF, I added support for Google-managed TLS certificates configured on a frontend TLS LB to avoid changing the IP address every time the container VM gets updated. This will also allow to expose a tcp/443 endpoint rather than tcp/80 (the last commit removes the public IP from the container VM).

Please consider this change to secure the service.

@auriaave auriaave marked this pull request as ready for review March 31, 2025 07:28
@aanm aanm merged commit c66e5a9 into cilium:master Mar 31, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanm aanm aanm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@auriaave @aanm @renovate-bot