Skip to content

Update MySQL example with proper docker image / example. #3412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 11, 2019

Conversation

teesloane
Copy link
Contributor

@teesloane teesloane commented May 30, 2019

I addressed some of the requested changes in #3402:

  • we now use an CircleCI mysql container image.
  • Removed link to third party github repo in favour of an inline example

Regarding SEO. Our doc ranks as the first result when querying google for CircleCI mysql

image


I'm not sure we need to split up this document into two different documents for mySQL and PostgreSQL respectively; the content is relatively similar and search results seem to be ok. Please let me know if I'm missing something regarding search results not showing up!

@teesloane teesloane requested a review from drazisil May 30, 2019 16:41
@michelle-luna michelle-luna merged commit 4f0b998 into master Jun 11, 2019
@michelle-luna michelle-luna deleted the tjs/update-mysql-example branch June 18, 2019 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants