Fix touch events being lost by listening to event.target on mobile #586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clauderic
force-pushed
the
fix-mobile-listener-node-issue
branch
from
48dfb5e to
e83cfe6
Compare
|
@clauderic do you have any plans of merging this in soon? i've tested out the commit and it does seem to resolve the issue with |
|
@clauderic Hi I wonder why this PR was not merged yet. any problem? |
oles-bolotniuk
approved these changes
Aug 27, 2020
|
@clauderic Seconding this one, please let us know if you're alive :) |
|
Ping here, please let us know if you can merge this in :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based off of #532. Resolves #578, #440 and #9.