Introduce errors-only value for cider-use-overlays
#3524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vemv
commented
Oct 15, 2023
cider-overlays.el
Outdated
| @@ -290,9 +292,10 @@ overlay." | |||
|
|
|||
|
|
|||
| ;;; Displaying eval result | |||
| (defun cider--display-interactive-eval-result (value &optional point overlay-face) | |||
| (defun cider--display-interactive-eval-result (value &optional point overlay-face error-p) | |||
There was a problem hiding this comment.
(We probably should make error-p mandatory so that consumers don't forget specifying this)
There was a problem hiding this comment.
That's a private API, so it's fine to change it. Perhaps it could be value-type instead, so it'd give us more flexibility in the future. I guess it can also stay as optional right after value, so at least the ordering of the args is more natural.
bbatsov
reviewed
Oct 16, 2023
cider-eval.el
Outdated
| @@ -865,7 +865,8 @@ when `cider-auto-inspect-after-eval' is non-nil." | |||
| (cider--display-interactive-eval-result | |||
| trimmed-err | |||
| end | |||
| 'cider-error-overlay-face))) | |||
| 'cider-error-overlay-face | |||
| :is-error))) | |||
There was a problem hiding this comment.
In Elisp it's more common to use symbols instead of keywords, so I'd go with 'is-error.
bbatsov
reviewed
Oct 16, 2023
| @@ -189,7 +189,16 @@ variable. | |||
| (setq cider-overlays-use-font-lock t) | |||
| ---- | |||
|
|
|||
| You can disable overlays entirely (and display results in the echo-area at the | |||
| You can restrict overlays to only be shown for errors | |||
There was a problem hiding this comment.
We might also explain why this may make sense. Without some extra context I doubt many people, other than the person who asked for this, will end up using it.
yqrashawn
added a commit
to yqrashawn/lispy
that referenced
this pull request
Oct 30, 2023
function changed at clojure-emacs/cider#3524 which included in cider version v1.8.3
yqrashawn
added a commit
to yqrashawn/lispy
that referenced
this pull request
Oct 30, 2023
function changed at clojure-emacs/cider#3524 which included in cider version v1.8.3
yqrashawn
added a commit
to yqrashawn/lispy
that referenced
this pull request
Oct 30, 2023
function changed at clojure-emacs/cider#3524 which included in cider version v1.9.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3522
It works as intended.
Cheers - V