Revert clojure.string alias back to str #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No objections from me. I think we had changed it for consistency, but I'm also used to using |
alexander-yakushev
force-pushed
the
string-to-str
branch
2 times, most recently
from
316c791 to
cba7fb5
Compare
alexander-yakushev
force-pushed
the
string-to-str
branch
from
cba7fb5 to
edd6382
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know this may look petty, but I lost count how many times I've typed
(str/, pressed complete, figured that the namespace probably doesn't have clojure.string required yet, going to the ns form only to discover it'sstringin this project. I'm not a fan of useless churn, but this is seriously annoying. Let's agree thatstr/is an "industry standard" and forget about this.