Skip to content

[stacktrace] Add ex-str-formatted message to analyzed causes #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 19, 2025

Conversation

alexander-yakushev
Copy link
Member

@alexander-yakushev alexander-yakushev commented Mar 19, 2025

To accommodate for changes I'm making in clojure-emacs/cider#3789, we need the triaged compiler exception string to be available within the analyzed exception itself, not just the stderr output. The solution is clunky, and I would do it differently if we didn't already have this cruft of sending one message per cause, but it's cheaper from the compatibility perspective to add it here.

The second commit is a minor addition. The new pmap in orchard.misc is more efficient and doesn't yank the Futures pool.


  • You've added tests to cover your change(s)
  • You've updated the changelog

@alexander-yakushev alexander-yakushev force-pushed the stacktrace-triage branch 2 times, most recently from 2529a55 to e162aae Compare March 19, 2025 07:57
@alexander-yakushev
Copy link
Member Author

Update: I also added the commit that removes printing customization from orchard.stacktrace and instead prints stuff with orchard.print that truncates long collections.

@alexander-yakushev
Copy link
Member Author

Merging to be able to review user-visible changes faster.

@alexander-yakushev alexander-yakushev merged commit 7c6215d into master Mar 19, 2025
20 checks passed
@alexander-yakushev alexander-yakushev deleted the stacktrace-triage branch March 19, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant