[profile] Port thunknyc/profile to Orchard #333
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As another milestone in my crusade against abandonware in CIDER,
orchard.profile
is intended to replace https://github.com/thunknyc/profile. This is a from-scratch implementation, so not much attribution is given. I dropped the parts of the API that cider-nrepl doesn't invoke; and users don't need them either because users should use a proper profiler, not this ersatz. Still, a few people in the survey reported usingcider-profile
, so let them enjoy this new version.As a way to display the results, I'm going with the new table view-mode just added to the inspector. Here's how the results will look like:
This will allow us to drop the custom
*cider-profile*
buffer, reuse the existing inspector machinery, give users the ability to click around, and even inspect the full list of timing samples (if anyone ever needs that).