Skip to content

[profile] Port thunknyc/profile to Orchard #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025
Merged

Conversation

alexander-yakushev
Copy link
Member

@alexander-yakushev alexander-yakushev commented Apr 7, 2025

As another milestone in my crusade against abandonware in CIDER, orchard.profile is intended to replace https://github.com/thunknyc/profile. This is a from-scratch implementation, so not much attribution is given. I dropped the parts of the API that cider-nrepl doesn't invoke; and users don't need them either because users should use a proper profiler, not this ersatz. Still, a few people in the survey reported using cider-profile, so let them enjoy this new version.

As a way to display the results, I'm going with the new table view-mode just added to the inspector. Here's how the results will look like:

image

This will allow us to drop the custom *cider-profile* buffer, reuse the existing inspector machinery, give users the ability to click around, and even inspect the full list of timing samples (if anyone ever needs that).


  • You've added tests to cover your change(s)
  • You've updated the changelog (if adding/changing user-visible functionality)

@bbatsov
Copy link
Member

bbatsov commented Apr 7, 2025

Impressive! I like how simple and short the new implementation is - only 188 lines!

Copy link
Member

@bbatsov bbatsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to mention it in the list of features in the README.

@alexander-yakushev alexander-yakushev force-pushed the profile branch 5 times, most recently from 76fdcac to c5a5e9c Compare April 8, 2025 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants