[print] Make orchard.print more consistent with CIDER printing #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-yakushev
force-pushed
the
print
branch
from
5318a51 to
3feb4eb
Compare
bbatsov
approved these changes
Apr 22, 2025
alexander-yakushev
force-pushed
the
print
branch
from
3feb4eb to
5924221
Compare
alexander-yakushev
force-pushed
the
print
branch
from
5924221 to
93cef7a
Compare
|
Nice! Thanks for fine tuning this! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to make the custom printing we do in inspector, debugger, and the customly inject print-methods in cider-nrepl more consistent with each other. This PR adds print handling for futures, promises, namespaces, multimethods (things that cider-nrepl already performs prettyfication of), downcases the custom printed representation names (again, like cider-nrepl does), and other minor things.