Adding support for Forum, Topic & GroupMembership #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In fact, this is not ready yet - looks like there is data on Zendesk (at least ours) which have different casing on TopicTypes (e.g. "articles" and "Articles"). I'll try and find a way of parsing both cases. |
| import org.zendesk.client.v2.model.SearchResultEntity; | ||
| import org.zendesk.client.v2.model.Ticket; | ||
| import org.zendesk.client.v2.model.User; | ||
| import org.zendesk.client.v2.model.*; |
There was a problem hiding this comment.
be explicit on all imports btw
|
Also, can you check off these items in the README.md as part of your pull request. |
|
Hi Stephen, Reformatted as requested, I also re-tested Topic.TopicType and the enums work fine, I'm not sure what happened previously :-s |
stephenc
added a commit
that referenced
this pull request
Nov 20, 2014
Adding support for Forum, Topic & GroupMembership
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Great client, I've added support for Forum, Topic and GroupMembership. I've tested as much as I can on the agent based endpoints.
Thanks
Tom