Skip to content

Implement additional Event types #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2015

Conversation

matthewtckr
Copy link
Contributor

Issue #24

@matthewtckr
Copy link
Contributor Author

The additional Event types were found in analyzing my organization's Ticket Audits, and we currently have a Zendesk Support case open to get these items publicly documented.

@matthewtckr
Copy link
Contributor Author

@reviewbybees

There's little doc on how to get this merged, let me know if there's a more-appropriate method than this.

Thanks,

@stephenc
Copy link
Collaborator

I just prefer to see the api documented before merging to master and releasing, but if you can share a public ticket where these event types are discussed that may suffice (depends on what's on the other end of the link)

@kzantow
Copy link

kzantow commented Oct 2, 2015

@matthewtckr agree with @stephenc - perhaps, at least add a brief class-level comment what the types are used for, if possible?

@matthewtckr
Copy link
Contributor Author

Will do. Waiting on the final publish from Zendesk, and I will update the pull request. Thank you

@matthewtckr
Copy link
Contributor Author

Updated the classes with Javadoc, including links to the Zendesk documentation that is now available for all three event types included.

stephenc added a commit that referenced this pull request Oct 12, 2015
Implement additional Event types
@stephenc stephenc merged commit 9262217 into cloudbees-oss:master Oct 12, 2015
@matthewtckr matthewtckr deleted the newevents branch October 13, 2015 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants