Skip to content

Add WCI WRANGLER_CI_OVERRIDE_NAME documentation #19699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: production
Choose a base branch
from

Conversation

cmsparks
Copy link
Contributor

@cmsparks cmsparks commented Feb 3, 2025

Summary

Document worker name override behavior in Workers Builds. These wrangler changes are included here:

Documentation checklist

  • The documentation style guide has been adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 files reviewed, 1 total issue(s) found.

Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
@ToriLindsay ToriLindsay requested a review from aninibread as a code owner April 16, 2025 10:32
Copy link
Contributor

hyperlint-ai bot commented Apr 16, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.


PR Change Summary

Documented the behavior of the WRANGLER_CI_OVERRIDE_NAME environment variable in Workers Builds, clarifying how it affects worker name overrides.

  • Added documentation for the WRANGLER_CI_OVERRIDE_NAME environment variable
  • Clarified worker name override behavior in the context of Wrangler versions greater than 3.xx
  • Updated troubleshooting section to reflect changes in worker name handling

Modified Files

  • src/content/docs/workers/ci-cd/builds/troubleshoot.mdx

How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

Copy link

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: cbac117
Status: ✅  Deploy successful!
Preview URL: https://69e9a547.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://csparks-add-wci-override-doc.cloudflare-docs-7ou.pages.dev

View logs

Copy link
Contributor

@ToriLindsay ToriLindsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmsparks I approved for PCX with a slight rephrasing suggestion for clarity.

@@ -26,6 +26,8 @@ The build system uses the `name` argument in the wrangler.toml to determine whic
This does not apply to [Wrangler Environments](/workers/wrangler/environments/) if the Worker name before the `-<env_name>` suffix matches the name in wrangler.toml.

For example, a Worker named `my-worker-staging` on the dashboard can be deployed from a repository that contains a wrangler.toml with the arguments `name = my-worker` and `[env.staging]` using the deploy command `npx wrangler deploy --env staging`.

Additionally, on Wrangler versions greater than 3.xx, Workers Builds will automatically override the name to match the Worker it is connected to using the `WRANGLER_CI_OVERRIDE_NAME` environment variable.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Additionally, on Wrangler versions greater than 3.xx, Workers Builds will automatically override the name to match the Worker it is connected to using the `WRANGLER_CI_OVERRIDE_NAME` environment variable.
On Wrangler v3 and up, Workers Builds automatically matches the name of the connected Worker by overriding it with the `WRANGLER_CI_OVERRIDE_NAME` environment variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product:workers Related to Workers product size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants