Skip to content

In the config doc mention that there are toml<->json online converters #20042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 30, 2025
Merged

In the config doc mention that there are toml<->json online converters #20042

merged 3 commits into from
Apr 30, 2025

Conversation

dario-piotrowicz
Copy link
Member

Summary

The changes here simply inform users that there are online converters from toml to json and viceversa

Not something hugely important but I figured it could be small useful tidbit for users

@github-actions github-actions bot added the product:workers Related to Workers product label Feb 17, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 17, 2025 •
edited
Loading

Preview URL: https://c125360c.preview.developers.cloudflare.com
Preview Branch URL: https://dario-toml-json-converter.preview.developers.cloudflare.com

Files with changes (up to 15)

Original Link Updated Link
https://developers.cloudflare.com/workers/wrangler/configuration/ https://dario-toml-json-converter.preview.developers.cloudflare.com/workers/wrangler/configuration/

@hyperlint-ai Hyperlint AI
Copy link
Contributor

hyperlint-ai bot commented Apr 30, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.

PR Change Summary

Updated the configuration documentation to include information about online converters between TOML and JSON formats.

  • Mentioned the availability of online converters for TOML and JSON formats.
  • Clarified that the configuration file format is the same across both languages, with only syntax differences.
  • Provided a specific example of an online converter (toml2jsonConverter).

Modified Files

  • src/content/docs/workers/wrangler/configuration.mdx
How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

@github-actions github-actions bot added size/s and removed size/xs labels Apr 30, 2025
@dario-piotrowicz
Copy link
Member Author

Thank you very much for the review @ToriLindsay 🫶

@dario-piotrowicz dario-piotrowicz merged commit c9cc9d4 into production Apr 30, 2025
12 checks passed
@dario-piotrowicz dario-piotrowicz deleted the dario/toml-json-converter branch April 30, 2025 16:44
GregBrimble pushed a commit that referenced this pull request May 1, 2025
@dario-piotrowicz @ToriLindsay @GregBrimble
In the config doc mention that there are toml<->json online converters (
80ee2ad 
#20042)

---------

Co-authored-by: ToriLindsay <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ToriLindsay ToriLindsay ToriLindsay approved these changes

@irvinebroque irvinebroque Awaiting requested review from irvinebroque irvinebroque is a code owner

@penalosa penalosa Awaiting requested review from penalosa

Assignees

@irvinebroque irvinebroque

@ToriLindsay ToriLindsay

Labels
product:workers Related to Workers product size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dario-piotrowicz @ToriLindsay @irvinebroque